Updating usb crates #469
Merged
Updating usb crates #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Nov 20, 2023
| @@ -50,8 +50,8 @@ impl USB1 { | |||
| usb_global: stm32::OTG1_HS_GLOBAL, | |||
| usb_device: stm32::OTG1_HS_DEVICE, | |||
| usb_pwrclk: stm32::OTG1_HS_PWRCLK, | |||
| _pin_dm: gpio::PA11<Analog>, | |||
| _pin_dp: gpio::PA12<Analog>, | |||
| _pin_dm: gpio::PA11<crate::gpio::Analog>, | |||
There was a problem hiding this comment.
This change is because clippy was throwing annoying warnings when the features weren't enabled about an unused Analog import
richardeoin
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Really awesome work on usb-device upstream, thanks @ryan-summers !
I re-tested the usb_serial and usb_rtic examples on a NUCLEO-H7A3ZI-Q and they worked correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the various usb-* crates, which just got updated releases last week.